Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stackblitz/vue): workaround for stackblitz bug #1742

Merged

Conversation

nstuyvesant
Copy link
Contributor

@nstuyvesant nstuyvesant commented Feb 5, 2024

Updates

  • StackBlitz 'vue' template does not load library correctly as ESM. Moved template to 'node' so vite does the loading.
  • Remove hard-coded package versions for demos. Either get the version the package uses or if the package doesn't use it and StackBlitz's template needs it, use the latest to ensure StackBlitz compatibility
  • Refactor Vue examples to use Vue 3.4 v-bind sugar.
  • Bump @nrwl/devkit

@nstuyvesant nstuyvesant requested review from theiliad and a team as code owners February 5, 2024 04:11
Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit e5d548d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/65c060099bdbc30008135a9b
😎 Deploy Preview https://deploy-preview-1742--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit e5d548d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/65c0600a93b4230008fdc271
😎 Deploy Preview https://deploy-preview-1742--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit e5d548d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/65c0600a4ac8b90008481395
😎 Deploy Preview https://deploy-preview-1742--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@theiliad theiliad merged commit def9bc5 into carbon-design-system:master Feb 5, 2024
4 checks passed
@theiliad theiliad deleted the stackblitz-vue-bug branch February 5, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants