Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): styles of export to csv button #1745

Conversation

markchou0225
Copy link
Contributor

@markchou0225 markchou0225 commented Feb 7, 2024

Closes #1730

Updates

  • Fix css selector or primary button in export to csv modal

Demo screenshot or recording

After fixing the css selector, we can see the styles in _modal.scss are applied.

Screenshot 2024-02-08 at 2 57 20 AM

@markchou0225 markchou0225 requested review from theiliad and a team as code owners February 7, 2024 18:56
Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit d095dc2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/65c3d272b466820007792d66
😎 Deploy Preview https://deploy-preview-1745--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit d095dc2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/65c3d272fb1b2a00088c2b41
😎 Deploy Preview https://deploy-preview-1745--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit d095dc2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/65c3d272bb4e220007e409ae
😎 Deploy Preview https://deploy-preview-1745--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@theiliad
Copy link
Member

theiliad commented Feb 7, 2024

thank you @markchou0225 🙌🏻

@theiliad theiliad merged commit 75c8281 into carbon-design-system:master Feb 7, 2024
4 checks passed
@theiliad theiliad added the type: bug 🐛 Something isn't working label Feb 7, 2024
@markchou0225 markchou0225 deleted the bug/1730-style-of-export-csv-button branch February 28, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Broken style for "Download as CSV" button in tabular representation
2 participants