Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lerna): revert prettier to 2.8.8 for now #1609

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fix(lerna): revert prettier to 2.8.8 for now #1609

merged 1 commit into from
Jul 6, 2023

Conversation

nstuyvesant
Copy link
Contributor

@nstuyvesant nstuyvesant commented Jul 6, 2023 •
edited
Loading

Updates

  • Revert to prettier 2.8.8 for lerna publish (no idea why it cares about the prettier version but it does)
  • Revert config file to CJS for now
  • Update .vscode/settings to look for CJS file
  • Update root-level package.json to point to prettier.config.cjs
  • Bug fix for Svelte 4
  • Bug fix for Vite

@nstuyvesant nstuyvesant requested review from theiliad, Akshat55 and a team as code owners July 6, 2023 17:34
@nstuyvesant nstuyvesant requested review from zvonimirfras and removed request for a team July 6, 2023 17:34
@netlify
Copy link

netlify bot commented Jul 6, 2023 •
edited
Loading

✅ Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 8f1712b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/64a6fb1e51ad2b0008e0eca6
😎 Deploy Preview https://deploy-preview-1609--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 6, 2023 •
edited
Loading

✅ Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 8f1712b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/64a6fb1e0d731a0008fde43c
😎 Deploy Preview https://deploy-preview-1609--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 6, 2023 •
edited
Loading

✅ Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 8f1712b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/64a6fb1eba06c900084c2fce
😎 Deploy Preview https://deploy-preview-1609--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

theiliad
theiliad approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theiliad theiliad merged commit 0bd1503 into carbon-design-system:master Jul 6, 2023
4 checks passed
@theiliad theiliad deleted the revert-prettier-version-for-lerna branch July 6, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theiliad theiliad theiliad approved these changes

@Akshat55 Akshat55 Awaiting requested review from Akshat55

@zvonimirfras zvonimirfras Awaiting requested review from zvonimirfras zvonimirfras is a code owner automatically assigned from carbon-design-system/carbon-charts

Assignees
No one assigned
Labels
affects: build-process type: bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nstuyvesant @theiliad