Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add tabularRepModal interface #1725

Merged
merged 10 commits into from
Jan 12, 2024
Merged

fix(types): add tabularRepModal interface #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a13ad05
feat(modal):customizability of chart modal
RiyaJethwa Dec 19, 2023
4ab799c
misspell error rectified
RiyaJethwa Dec 28, 2023
ab776a7
property name change and formatTable function parameter count changed…
RiyaJethwa Jan 10, 2024
fbeac78
modal property name changed to tabularRepModal
RiyaJethwa Jan 11, 2024
65c9cbf
Merge branch 'master' into modalCustomizability-#1700
theiliad Jan 11, 2024
e9cbf3d
Update pie.ts
theiliad Jan 11, 2024
b33c4b0
Update cartesian-charts.ts
theiliad Jan 11, 2024
b04ce29
tableCellFormatter receiving entire cell data and removal of tableFor…
RiyaJethwa Jan 12, 2024
0f1c31e
addition of TabularRepCustomizationOptions interface
RiyaJethwa Jan 12, 2024
6becf2b
Merge branch 'master' into modalCustomizability-#1700
theiliad Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/core/src/interfaces/charts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ import type {
StackedBarOptions,
ToolbarOptions,
TooltipOptions,
ZoomBarsOptions
ZoomBarsOptions,
TabularRepCustomizationOptions
} from './components'
import type {
AxesOptions,
Expand Down Expand Up @@ -166,6 +167,10 @@ export interface BaseChartOptions {
* whether this type of chart is experimental
*/
experimental?: boolean
/**
* options related to table data customization
*/
tabularRepModal?: TabularRepCustomizationOptions
}

/**
Expand Down
14 changes: 14 additions & 0 deletions packages/core/src/interfaces/components.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,3 +252,17 @@ export interface ZoomBarOptions {
*/
data?: object[]
}

/**
* customize the Tabular Data
*/
export interface TabularRepCustomizationOptions {
/**
* option to customize the Table Headers
*/
tableHeadingFormatter?: (headings: string[]) => string[]
/**
* option to customize the Table Cells
*/
tableCellFormatter?: (cells: string[][]) => string[][]
}