Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(heatmap-choropleth):legend hidden when data array is empty #1763

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix(heatmap-choropleth):legend hidden when data array is empty #1763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/core/src/charts/choropleth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ export class ExperimentalChoroplethChart extends Chart {

const isLegendEnabled =
getProperty(configs, 'legend', 'enabled') !== false &&
this.model.getOptions().legend.enabled !== false
this.model.getOptions().legend.enabled !== false &&
this.model.getData().length > 0

// Decide the position of the legend in reference to the chart
const fullFrameComponentDirection = LayoutDirection.COLUMN_REVERSE
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/charts/heatmap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ export class HeatmapChart extends AxisChart {

const isLegendEnabled =
getProperty(configs, 'legend', 'enabled') !== false &&
this.model.getOptions().legend.enabled !== false
this.model.getOptions().legend.enabled !== false &&
this.model.getData().length > 0

// Decide the position of the legend in reference to the chart
const fullFrameComponentDirection = LayoutDirection.COLUMN_REVERSE
Expand Down
Loading