Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(all packages): missing options, package.json and lint fixes #1849

Merged
merged 10 commits into from
Jun 15, 2024

Conversation

nstuyvesant
Copy link
Contributor

@nstuyvesant nstuyvesant commented Jun 15, 2024

Updates

  1. Added StackedBarChartOptions to exports for all packages. Closes [Bug]: StackedBarChartOptions is missing from the typescript exports for carbon charts react #1845
  2. For @carbon/charts-react move react and react-dom to devDependencies and make peerDependencies to match @carbon/react. Closes Does @carbon/charts-react support React 17? #1841
  3. Similar to item 2 but for Vue (proactive).
  4. Minor lint changes to remove errors related to demos (missing props, prop types, const vs. let).
  5. More JSDoc comments.
  6. Drop D3 as a peerDependency for core as it's inadvertently been getting bundled all along (total JavaScript bundle size is 206.3K gzipped). The size has come down quite a bit due to more efficient imports implemented back in 1.9.x. Benefit: setup process is simpler and the size trade-off is minimal (and again, was already in the bundle).

@nstuyvesant nstuyvesant requested review from theiliad and a team as code owners June 15, 2024 13:05
Copy link

netlify bot commented Jun 15, 2024

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 2f16305
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/666da867e0c43a0008b46a7b
😎 Deploy Preview https://deploy-preview-1849--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 15, 2024

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 2f16305
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/666da867567c7b000861145e
😎 Deploy Preview https://deploy-preview-1849--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 15, 2024

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 2f16305
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/666da8671c19dd00080e55b5
😎 Deploy Preview https://deploy-preview-1849--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nstuyvesant nstuyvesant changed the title fix(all packages): missing options, package.json fixes fix(all packages): missing options, package.json and lint fixes Jun 15, 2024
Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theiliad theiliad merged commit a43f0eb into carbon-design-system:master Jun 15, 2024
5 checks passed
@theiliad theiliad deleted the fix-1845-1841 branch June 15, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants