Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump to Angular 18 #1861

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

nstuyvesant
Copy link
Contributor

Updates

  • Upgrade @carbon/charts-angular to Angular 18.

Demo screenshot or recording

image

@nstuyvesant nstuyvesant requested review from theiliad and a team as code owners June 26, 2024 19:51
Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for carbon-charts-docs ready!

Name Link
🔨 Latest commit 6fb843b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-docs/deploys/667cbc907f109d00083e6260
😎 Deploy Preview https://deploy-preview-1861--carbon-charts-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 6fb843b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/667cbc90432edd000864d3ef
😎 Deploy Preview https://deploy-preview-1861--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 6fb843b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/667cbc90c48efe0008014e57
😎 Deploy Preview https://deploy-preview-1861--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nstuyvesant
Copy link
Contributor Author

Once the new version is published, please run npm dist-tag add @carbon/charts-angular@1.17.1 angular18 (assuming 1.17.1 is the next version).

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 6fb843b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/667cbc90c2867a00084bbf06
😎 Deploy Preview https://deploy-preview-1861--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nstuyvesant nstuyvesant changed the title chore(deps): bump to Angular 18 chore(deps): bump to Angular 18 (DO NOT MERGE) Jun 27, 2024
@nstuyvesant nstuyvesant changed the title chore(deps): bump to Angular 18 (DO NOT MERGE) chore(deps): bump to Angular 18 Jun 27, 2024
Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theiliad theiliad merged commit 7d97c9d into carbon-design-system:master Jun 27, 2024
6 checks passed
@theiliad theiliad deleted the angular-18 branch June 27, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants