-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(network): add network graph #435
Conversation
…s into refactor-network-charts-test
…s into network-graph
…s into network-graph
@j1mie I think the |
@theiliad gotcha. Not seeing the Travis error after merging with master. |
Problem is I don't see your demo on the deploy preview now. Perhaps it's gone with the |
@theiliad Refactored based on recent updates |
@theiliad any updates on this |
Hi Jimmy, still trying to get design to take a look at this component 😞 |
Hi @j1mie there are couple things that stand out from the specs I saw from @cameroncalder The network card heading is a little high and starts to look top aligned with the icon. This should appear center aligned with the icon. The network link line uses a different style arrowhead and bend. Was this a later design change? The network link line's color is using the older version of gray-50 that was I like the shorter 24px that are between the nods in the preview link, but the specs have a taller 32px between. Maybe this was another design change that was done in code and the specs not updated. I would recommend going the full 80px between the nodes. Right now it looks like it's 76px at the default zoom level. |
Is there an ETA on when would this work be completed? We could use this network chart in our project 👍 |
Just bumping this for an update. It's been 9 months since this PR was opened. |
Hi there, unfortunately these changes did not make it upstream, I'm going to close this out for the time being and will post here again if the situation changes. |
Hi, based on the survey we ran 3 months ago, here's the current list of items based on priority
Network diagram is currently number 8 on the list |
Thank you for the update! |
Is there an experimental branch where people can contribute half baked solutions and get help from other people? |
Hi @j1mie, Any update on this PR? |
Closing in favor of #1022 |
This is an initial PR for the network graph component.
There is still outstanding work to complete for expansion, mini map etc. however in order to get the ball rolling and keep PR sizes reasonable, I can submit these as a series of PRs, if that's all good with you guys 🙌 (I've left a list out upcoming items at the bottom of the PR description)
Adds
@carbon/icons
and@carbon/icon-helpers
dependencies to support the rendering of icons in the network graphpackages/core/src/charts/network.ts
packages/core/src/components/graphs/network/index.ts
network-card
sub component atpackages/core/src/components/graphs/network/network-card.ts
, a function that renders out the card componentnetwork-line
sub component atpackages/core/src/components/graphs/network/network-line.ts
, a function that renders out lines components and their markersnetwork
component atpackages/core/src/components/graphs/network/network.ts
that calls both the network line and network card functions, and also calls d3 zoom functiond3-path
for correct spacing of lines between cards, atpackages/core/src/components/graphs/network/utils/build-path-string.ts
packages/core/src/components/graphs/network/utils/get-icon-string.ts
network
,network-card
,network-line
atpackages/core/src/styles/graphs/network/
Changed
type.options
inpackages/core/demo/index.ts
packages/core/src/components/index.ts
packages/core/src/configuration.ts
packages/core/src/index.ts
Questions / Comments
Todos / outstanding work
Demo screenshot or recording
Network chart (white theme)
![Screenshot 2019-12-12 at 10 51 16](https://user-images.githubusercontent.com/12685163/70706282-87c61300-1ccd-11ea-8963-99b02c9d086c.png)
Network chart / focussed card (white theme)
![Screenshot 2019-12-12 at 10 51 21](https://user-images.githubusercontent.com/12685163/70706284-885ea980-1ccd-11ea-86cb-8efc413eeb11.png)
Network chart (g10 theme)
![Screenshot 2019-12-12 at 10 51 35](https://user-images.githubusercontent.com/12685163/70706285-885ea980-1ccd-11ea-95db-6d435b6d49e2.png)
Network chart (g90 theme)
![Screenshot 2019-12-12 at 10 51 45](https://user-images.githubusercontent.com/12685163/70706287-885ea980-1ccd-11ea-97f1-6dfb72faa1f2.png)
Network chart (g100 theme)
![Screenshot 2019-12-12 at 10 51 56](https://user-images.githubusercontent.com/12685163/70706288-885ea980-1ccd-11ea-8ec8-3af261beb598.png)
Pan, drag, zoom behaviour
![Screen Recording 2019-12-12 at 10 54 32](https://user-images.githubusercontent.com/12685163/70706962-ecce3880-1cce-11ea-85e2-1e176115d961.gif)
Review checklist (for reviewers only)