Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidenav Item is ignoring routeExtras #2904

Closed
Licen-it opened this issue May 27, 2024 · 1 comment · Fixed by #2905
Closed

Sidenav Item is ignoring routeExtras #2904

Licen-it opened this issue May 27, 2024 · 1 comment · Fixed by #2905

Comments

@Licen-it
Copy link
Contributor

Licen-it commented May 27, 2024

Detailed description

Describe in detail the issue you're having.

the change introduced in #2812 is enabling the router by default, but is not passing the routeExtras, resulting in breaking links for who was relying on those extras (like relativeTo)

Is this a feature request (new component, new icon), a bug, or a general issue?

bug

Is this issue related to a specific component?

Sidenav Item

What did you expect to happen? What happened instead? What would you like to see changed?

routeExtras should be properly consumed and passing the single option to the routerLink directive

What browser are you working in?

any

What version of the Carbon Design System are you using?

latest

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Zelta

Copy link

🎉 This issue has been resolved in version 5.26.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant