fix: pass route extras in routerLink

[Akshat55]

Closes #2904

Changelog

Changed

• Now calling navigate function on anchor link click which will pass in routeExtras.

[netlify]

✅ Deploy Preview for carbon-components-angular ready!

Name	Link
🔨 Latest commit	07c566d
🔍 Latest deploy log	https://app.netlify.com/sites/carbon-components-angular/deploys/665783341c625d0008c75257
😎 Deploy Preview	https://deploy-preview-2905--carbon-components-angular.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

🎉 This PR is included in version 5.26.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[klaascuvelier]

Hey, I am a bit late here with feedback as this MR has been merged already.

I think the current implementation effectively breaks the idea of the original change. The idea was to rely on the functionality of the directives solely to do navigation and navigation state checks, skipping any custom JS. This would allow for correct cmd + click behavior and so on.
I think the correct fix here would have been to add the navigation extras into the template where now the onclick handler was added.

[Licen-it]

@klaascuvelier yeah it would make sense....i didn't think about the cmd + click, but the only pain would be that then passed into the template they wouldn't be a nice since object, but each property would need to be specified separately.
I have an idea @Akshat55, but not sure if that would be ok for carbon team...we could have a directive extending RouterLink directive which is accepting a single object of type NavigationExtras and in the constructor setting each property in this object to the parent class (in a loop way so that if they add/remove any, you won't have to update this code)

[klaascuvelier]

Thanks for you reply @Licen-it.
I think adding all the navigation extras in the template of this component should not be too much work, just a one time job.
I'll draft something up quickly asap. I'll start by creating a new issue so we can take the discussion there. Thanks for collaborating on this and my apologies for breaking stuff :)

[Licen-it]

Thanks for you reply @Licen-it. I think adding all the navigation extras in the template of this component should not be too much work, just a one time job. I'll draft something up quickly asap. I'll start by creating a new issue so we can take the discussion there. Thanks for collaborating on this and my apologies for breaking stuff :)

Well I was mainly thinking about future proof solution, so that even if a later angular version is changing it will work fine...something to easily support different versions of angular without breaking