fix(dropdown): fix ssr issue (#1639)

The `onDestroy` hook is also run during SSR, so returning destruction function from `onMount` should do the trick. For #1638
carbon-design-system · Jan 25, 2023 · 8cb5d53 · 8cb5d53
1 parent afa692c
commit 8cb5d53
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/Dropdown/Dropdown.svelte b/src/Dropdown/Dropdown.svelte
@@ -98,7 +98,7 @@
   /** Obtain a reference to the button HTML element */
   export let ref = null;
 
-  import { createEventDispatcher, onDestroy, onMount } from "svelte";
+  import { createEventDispatcher, onMount } from "svelte";
   import WarningFilled from "../icons/WarningFilled.svelte";
   import WarningAltFilled from "../icons/WarningAltFilled.svelte";
   import {
@@ -159,11 +159,11 @@
     if (parent) {
       parent.addEventListener("click", pageClickHandler);
     }
-  });
 
-  onDestroy(() => {
-    if (parent) {
-      parent.removeEventListener("click", pageClickHandler);
+    return () => {
+      if (parent) {
+        parent.removeEventListener("click", pageClickHandler);
+      }
     }
   });
 </script>