Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextInput] helperText enhancements #1633

Open
2 tasks done
Tracked by #1888
theetrain opened this issue Jan 17, 2023 · 2 comments
Open
2 tasks done
Tracked by #1888

[TextInput] helperText enhancements #1633

theetrain opened this issue Jan 17, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers v11 Carbon v11 feature

Comments

@theetrain
Copy link
Collaborator

theetrain commented Jan 17, 2023 •
edited
Loading

These also apply to <PasswordInput />.
@theetrain theetrain added bug Something isn't working good first issue Good for newcomers labels Jan 17, 2023
@carsonmccue carsonmccue mentioned this issue Feb 19, 2023
Merged
theetrain pushed a commit that referenced this issue Feb 19, 2023
@carsonmccue
fix(textinput/passwordinput): apply aria-describedby to hint text
b435be4 
* Aria-describedby

Resolves base aria-describedby attribute from #1633.

* Update PasswordInput.svelte
@theetrain
Copy link
Collaborator Author

aria-describedby fix now available in v0.73.1.

@theetrain theetrain mentioned this issue Jan 13, 2024
Closed
8 tasks
SimpleProgrammingAU pushed a commit to SimpleProgrammingAU/carbon-components-svelte that referenced this issue Jan 14, 2024
Contributes to [TextInput] helperText enhancements carbon-design-syst…
00338eb 
…em#1633
@SimpleProgrammingAU SimpleProgrammingAU mentioned this issue Jan 14, 2024
Merged
theetrain added a commit that referenced this issue Jan 17, 2024
@SimpleProgrammingAU @theetrain
feat!: TextInput v11 Styles (#1889)
c436dbd 
* Initial commit

* Fixes [FluidForm] TextInput error icon is misplaced #1667

* Contributes to [TextInput] helperText enhancements #1633

* Adopts Standardize props and events #1621

* Added slots for Standardize props and events #1621

* Added pointer events, updated skeleton TextInput v11 #1888

* Address a bug in the word counter regex

* Update src/TextInput/TextInput.svelte

Correcting type attribute definition for HTML attributes

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Update src/TextInput/TextInput.svelte

Correcting type attribute definition for HTML attributes

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Update src/TextInput/TextInput.svelte

Explicitly define default value for `size`

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Adopted suggested changes

* Updated `TextInput.test`; added forgotten files from previous

---------

Co-authored-by: Samuel Janda <hi@simpleprogramming.com.au>
Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>
@theetrain theetrain added the v11 Carbon v11 feature label Jan 17, 2024
@theetrain
Copy link
Collaborator Author

This fix will be included once v11 styles are shipped. See #1888.

metonym pushed a commit that referenced this issue Mar 23, 2024
@SimpleProgrammingAU @theetrain @metonym
feat!: TextInput v11 Styles (#1889)
9efe525 
* Initial commit

* Fixes [FluidForm] TextInput error icon is misplaced #1667

* Contributes to [TextInput] helperText enhancements #1633

* Adopts Standardize props and events #1621

* Added slots for Standardize props and events #1621

* Added pointer events, updated skeleton TextInput v11 #1888

* Address a bug in the word counter regex

* Update src/TextInput/TextInput.svelte

Correcting type attribute definition for HTML attributes

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Update src/TextInput/TextInput.svelte

Correcting type attribute definition for HTML attributes

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Update src/TextInput/TextInput.svelte

Explicitly define default value for `size`

Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>

* Adopted suggested changes

* Updated `TextInput.test`; added forgotten files from previous

---------

Co-authored-by: Samuel Janda <hi@simpleprogramming.com.au>
Co-authored-by: Enrico Sacchetti <esacchetti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers v11 Carbon v11 feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theetrain