Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContextMenu should be constrained to the viewport #577

Closed
brunnerh opened this issue Mar 21, 2021 · 1 comment · Fixed by #588
Closed

ContextMenu should be constrained to the viewport #577

brunnerh opened this issue Mar 21, 2021 · 1 comment · Fixed by #588
Assignees
@metonym
Labels
bug Something isn't working

Comments

@brunnerh
Copy link
Contributor

Currently the context menu always opens at the cursor to the bottom right, even if there is not enough space. Likewise sub-menus always open to the right.

Examples from the Windows Explorer context menu that mitigate this correctly:

Menu opening upwards at the bottom of the screen:

image

Sub-menu opening to the other side, if there is no space to the right:

image
@metonym metonym self-assigned this Apr 2, 2021
@metonym metonym added the bug Something isn't working label Apr 2, 2021
metonym added a commit that referenced this issue Apr 2, 2021
@metonym
fix(context-menu): set initial y offset of context menu based on wind…
2974556 
…ow height #577
metonym added a commit that referenced this issue Apr 2, 2021
@metonym
fix(context-menu): render submenu based on viewport constraints #577
6dbbe7a
@metonym metonym mentioned this issue Apr 2, 2021
Merged
metonym added a commit that referenced this issue Apr 2, 2021
@metonym
Alignment with Carbon version 10.32 (#588)
fa9b90c 
* feat(code-snippet): add copy functionality

- docs: add custom feedback copy text example

* feat(tile): support disabled state for SelectableTile, RadioTile

Closes #539

* build(rollup): add clipboard-copy to globals

* feat(copy-button): add copy functionality

* feat(content-switcher): deprecate the light prop

- docs: remove the light variant example

* fix(toolbar-search): remove outer div

* feat(search): add searchClass prop

* fix(composed-modal): set hasScrollingContent class on ModalBody

* docs(data-table): add expandable size examples

* feat(tooltip): add TooltipFooter component

* fix(time-picker): correctly display invalidText

* feat(breadcrumb): support overflow menu

* feat(multi-select): export inputRef prop

* chore(deps-dev): upgrade carbon-components to v10.32.0

* feat(form): add noMargin prop to FormGroup

* docs(tooltip): document TooltipFooter

* feat(context-menu): support danger kind for ContextMenuOption

* feat(data-table): support rendering empty table header in skeleton

* refactor(types): use shorter import path in DataTableSkeleton

* feat(data-table): allow sorting to be disabled for a specific header

* docs(data-table): update example to desort the Protocol header

As an example, it makes more sense because all the values ("http") are the same.

* fix(context-menu): set initial y offset of context menu based on window height #577

* fix(context-menu): render submenu based on viewport constraints #577
@metonym
Copy link
Collaborator

metonym commented Apr 2, 2021

Fixed and released in version 0.32.0

context-menu-position

@maisonsmd maisonsmd mentioned this issue Nov 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metonym metonym

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alignment with Carbon version 10.32 carbon-design-system/carbon-components-svelte
2 participants
@brunnerh @metonym