Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-table): do not overwrite row.cells property #1336

Merged
merged 3 commits into from
Jun 5, 2022
Merged

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Jun 5, 2022

Currently, DataTable will add a cells property to each row which contains computed metadata for each header (e.g., key, display value, resolved value if using nested headers).

This is undesirable as it overrides the "cells" property in a row.

Although technically a breaking change, I'm considering this a fix as no row properties should be overridden in the first place.

Additional changes:

  • chore: touch up prop descriptions (use periods where needed)
  • refactor: remove unneeded third argument in resolvePath()
  • perf: when resolving path, early return object[path] if value exists

@metonym
Copy link
Collaborator Author

metonym commented Jun 7, 2022

Fixed in v0.65.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant