feat(ui-shell): add preventCloseOnClickOutside to HeaderAction
#1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonym
approved these changes
Feb 19, 2023
There was a problem hiding this comment.
Tested locally, LGTM.
Added the new parameter to HeaderAction.svelte but running yarn build:docs changes automatically other files, how to prevent that?
Weird – it seemed like a formatting issue, maybe an outdated version of Prettier. I re-ran yarn build:docs and it looks good now.
metonym
changed the title
preventCloseOnClickOutside to HeaderAction
|
Released in v0.77.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the new parameter to HeaderAction.svelte but running
yarn build:docschanges automatically other files, how to prevent that?fixes #1624