fix(expandable-tile): set tile height using resize observer #1738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1730
Currently, the
ExpandableTile
does not dynamically set the height of the above-the-fold content. In cases where the content is dynamic (a lot of text), this can result in clipped content.This PR aims to fix this problem by using the Resize Observer to set the height of the tile, and adjust it if the height changes. It implements the approach of the upstream React library almost verbatim.
In terms of behavior, this should not be a breaking change since you can still specify a custom tile height on the "above" and "below" slots.
Changes
ExpandableTile
to use Resize Observer to set the tile max heightExample
In the following example, I am clicking a button that doubles the text in the above-the-fold tile. Note how the tile height adjusts itself dynamically.
expandable-tile-double.mov
Issue #1730 (before)
expandable-tile-ex-before.mov
Issue #1730 (after)
expandable-tile-ex-after.mov