chore(deps-dev): upgrade svelte-check to version 3
#1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonym
force-pushed
the
upgrade-svelte-check
branch
from
ede90f0
to
2734857
Compare
This was referenced Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously attempted to upgrade the major version of
svelte-checkin #1703.One reason for this upgrade is to better diagnose #1740
In CI,
svelte-checkwould error out, as it would attempt to loadsvelte.config.jsunderdocs. I was not able to reproduce this locally.I RTFM and updated the command args to apply
no-tsconfigandignoreto only type check Svelte files intests. This seems to pass CI.