Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make titleText slottable in MultiSelect, ComboBox #1750

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

sachinbhutani
Copy link
Contributor

Fix #1747

Copy link
Collaborator

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – thanks for also applying this to the ComboBox.

One small change I made was to update the conditional wrapping the label, since the label is only rendered if titleText is truthy:

- {#if titleText}
+ {#if titleText || $$slots.titleText}

@metonym metonym changed the title feat(multi-select, combo-box): make titleText slottable feat: make titleText slottable in MultiSelect, ComboBox Jun 12, 2023
@metonym metonym merged commit 0b4f19c into carbon-design-system:master Jun 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiSelect does not have a label/titleText slot
2 participants