fix(skeleton-text): fix rows reactivity in paragraph variant

[metonym]

Fixes #1793

This refactors SkeletonText to use a more declarative approach: the Array.from method in the markup instead of a for loop inside of a reactive statement.

[theetrain]

This works well, though I couldn't reproduce the issue reported in #1793.

I likely misinterpreted it. Here's my attempt: https://svelte.dev/repl/078ab3788d514d3fbf9724d933e39b9b?version=4.2.0

Side note, the scripts build:docs and build:css won't work until we switch to ESM; or were you able to run them and publish recent packages some other way?

[metonym]

Side note, the scripts build:docs and build:css won't work until we switch to ESM; or were you able to run them and publish recent packages some other way?

Interesting – I'm still able to run these commands. Curious as to why they require ESM?

[theetrain]

Not sure either, here's my output—includes yarn and node versions:

➜  carbon-components-svelte-legacy git:(fix-skeleton-text) yarn build:docs
yarn run v1.22.19
warning ../../../package.json: No license field
$ node scripts/build-docs
/.../carbon-components-svelte-legacy/scripts/build-docs.js:3
const { sveld } = require("sveld");
                  ^

Error [ERR_REQUIRE_ESM]: require() of ES Module /.../sveld/lib/index.js from /.../carbon-components-svelte-legacy/scripts/build-docs.js not supported.
Instead change the require of index.js in /.../carbon-components-svelte-legacy/scripts/build-docs.js to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (/.../carbon-components-svelte-legacy/scripts/build-docs.js:3:19) {
  code: 'ERR_REQUIRE_ESM'
}

Node.js v18.16.0

In package.json, "type": "module" or "commonjs" don't seem to influence my output.

[metonym]

I'm using:

• Yarn 1.22.19
• Node 18.16.0

Is it possible that you were using a symlinked version of sveld when working on carbon-design-system/sveld#108?

[theetrain]

Yes, it was a symlink. Works now!

As for the bug, what are the reproduction steps? It seems to work fine on v0.79.0: https://svelte.dev/repl/078ab3788d514d3fbf9724d933e39b9b?version=4.2.0

[metonym]

I was also no able to reproduce it in later version of Svelte. However, I feel that refactoring to avoid the for loop inside the reactive statement is worth it.