Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-shell): forward onclick event for HeaderActionLink #1797

Merged
merged 1 commit into from
Aug 26, 2023
Merged

feat(ui-shell): forward onclick event for HeaderActionLink #1797

merged 1 commit into from
Aug 26, 2023

Conversation

mgreminger
Copy link
Contributor

As mentioned in #1796, this change forwards the on:click event from the wrapped anchor element for the HeaderActionLink component similar to other UIShell components that wrap anchor elements such as HeaderPanelLink, SideNavLink, or SkipToContent.

closes #1796

metonym
metonym approved these changes Aug 26, 2023
View reviewed changes
Copy link
Collaborator

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@metonym metonym merged commit e5675eb into carbon-design-system:master Aug 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metonym metonym metonym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forward onclick event for HeaderActionLink
2 participants
@mgreminger @metonym