feat(data-table): pass row to display function

[Pierstoval]

This will allow display usage to use the whole object for use with computed values, or when needing multiple fields to show more than one element (like "item actions" that might need more than one field, for instance).

[metonym]

Thanks for taking the time – I think this is a valuable change.

The docs/types are auto-generated.

Can you update the JSDoc types in DataTable.svelte (Lines 5, 6, 10) and run yarn build:docs?

[Pierstoval]

Can you update the JSDoc types in DataTable.svelte (Lines 5, 6, 10) and run yarn build:docs?

According to the docs, only line 10 needs update: the "display" method receives the row object only for cells, not headers, am I right?

Just rebased & pushed an update

[metonym]

I believe that the display is reflected in the DataTableNonEmptyHeader and DataTableEmptyHeader interfaces.

When testing the types, I see this:

Repro: try using row in the type test for DataTable:

carbon-components-svelte/tests/DataTable.test.svelte

Line 179 in aae2dd4

{ key: 'cost', value: 'Cost', display: (cost) => cost + ' €' },

[Pierstoval]

I don't see a reason to make this change on headers: row object should not be accessible when displaying headers 🤔

This means two things:

• The row object should be nullable for headers, and non-null for rows, I don't know how to do that
• The display function is overriden from the headers object, that's probably the cause of these typing issues:
  

  carbon-components-svelte/src/DataTable/DataTable.svelte

  Lines 200 to 204 in aae2dd4

  	rows[row.id] = headerKeys.map((key, index) => ({
  	key,
  	value: resolvePath(row, key),
  	display: headers[index].display,
  	}));

I think we should change the behavior for that.

I just pushed a fix to add row?: ... to header-related display functions, and kept row: ... for cell-related.

I'm not sure the rest of the PR is okay, feel free to make more comments 👌

[Pierstoval]

Thank you @metonym !

[metonym]

Released in v0.81.0