fix(tile-group): add name and required props
#1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunnerh
reviewed
Oct 3, 2023
src/Tile/RadioTile.svelte
Outdated
| @@ -23,10 +26,16 @@ | |||
| /** Specify a name attribute for the input */ | |||
| export let name = ""; | |||
There was a problem hiding this comment.
Maybe also switch the name default to undefined so the attribute is not added without value.
Comment on lines
+34
to
+37
| groupName: readonly(groupName), | ||
| groupRequired: readonly(groupRequired), |
There was a problem hiding this comment.
Stores do not appear to be defined yet; should be writable and updated reactively from props at the end of the <script> along the lines of:
$: $groupName = name;
$: $groupRequired = required;
brunnerh
reviewed
Oct 3, 2023
src/Tile/RadioTile.svelte
Outdated
| @@ -23,10 +26,16 @@ | |||
| /** Specify a name attribute for the input */ | |||
| export let name = ""; | |||
|
|
|||
| import { getContext } from "svelte"; | |||
| import { getContext, readable } from "svelte"; | |||
There was a problem hiding this comment.
That's from 'svelte/store'
metonym
force-pushed
the
fix-tile-group
branch
from
fc515c5
to
485ae17
Compare
metonym
force-pushed
the
fix-tile-group
branch
from
485ae17
to
5676a70
Compare
This was referenced Oct 3, 2023
|
Released in v0.81.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1037, fixes
TileGroupto forwardname/requiredprops to its group of inputs.