Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UIShell): add persistentHamburgerMenu prop to Header #396

Merged
merged 7 commits into from
Nov 18, 2020
Merged

feat(UIShell): add persistentHamburgerMenu prop to Header #396

merged 7 commits into from
Nov 18, 2020

Conversation

josefaidt
Copy link
Contributor

  • adds persistentHamburgerMenu prop to Header component
  • fixes collapse logic in SideNav
  • overrides isSideNavOpen logic when persisting hamburger menu

ref #374

@josefaidt josefaidt added the enhancement New feature or request label Nov 12, 2020
@vercel
Copy link

vercel bot commented Nov 12, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-svelte/carbon-components-svelte/5x4bifi3a
✅ Preview: https://carbon-components-svelte-git-374-header-hamburger-persistence.carbon-svelte.vercel.app

albertms10
albertms10 approved these changes Nov 13, 2020
View reviewed changes
src/UIShell/SideNav/SideNav.svelte Outdated Show resolved Hide resolved
metonym
metonym requested changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a usage example?

@metonym metonym merged commit d9e14b2 into master Nov 18, 2020
@metonym metonym deleted the 374-header-hamburger-persistence branch November 20, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metonym metonym metonym approved these changes

@albertms10 albertms10 albertms10 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josefaidt @metonym @albertms10