Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Password input] Password input - Add the password visibility #807

Closed
4 tasks done
thyhmdo opened this issue May 7, 2024 · 1 comment
Closed
4 tasks done

[Password input] Password input - Add the password visibility #807

thyhmdo opened this issue May 7, 2024 · 1 comment

Comments

@thyhmdo
Copy link
Member

thyhmdo commented May 7, 2024

Problem

Missing the password visibility toggle


Reference

Storybook link example: https://react.carbondesignsystem.com/?path=/story/components-textinput--toggle-password-visibility

image


Tasks

  • Fluid styles
  • Add the "eye" icon + dot symbol when turning this prop on

Review

  • Carbon
  • Figma
@laurenmrice
Copy link
Member

@thyhmdo We do have the default style under Password input in Figma, but we don't have the fluid style. Juan may have more context as to why it was split into its own component page.

@laurenmrice laurenmrice added this to the 2024 Q2 milestone May 8, 2024
@thyhmdo thyhmdo self-assigned this May 30, 2024
@thyhmdo thyhmdo changed the title [Text input] Text input - Add the password visibility [Password input] Password input - Add the password visibility Jun 4, 2024
@thyhmdo thyhmdo closed this as completed by moving to ✅ Done in Design System Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants