Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masthead L0: active search needs hover and focus states for icons #117

Closed
larahanlon2 opened this issue Sep 23, 2019 · 0 comments
Closed

Masthead L0: active search needs hover and focus states for icons #117

larahanlon2 opened this issue Sep 23, 2019 · 0 comments
Assignees
@kennylam
Labels
bug Something isn't working dev Needs some dev work severity 2 Affects major functionality, has a workaround

Comments

@larahanlon2
Copy link

There is currently no hover or focus state for the search and close icon when the search bar is active and open. They should look like this:

Screen Shot 2019-09-23 at 1 40 36 PM

Screen Shot 2019-09-23 at 1 34 33 PM
@larahanlon2 larahanlon2 added the dev Needs some dev work label Sep 23, 2019
@jeffchew jeffchew added the bug Something isn't working label Sep 26, 2019
@RobertaJHahn RobertaJHahn added the severity 2 Affects major functionality, has a workaround label Sep 26, 2019
@kennylam kennylam mentioned this issue Oct 11, 2019
Merged
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Mar 16, 2022
@asudoh
chore(devenv): simplify how to run React Storybook (carbon-design-sys…
3dd97af 
…tem#117)

This change backs out some portion of carbon-design-system#100, given React wrapper had to
be pre-built to run development mode of Storybook (for React). The
deployed (static) mode of Storybook still depends on pre-built version
of React wrapper, but it's OK as we can simply add it to the build
process.
annawen1 pushed a commit that referenced this issue Sep 15, 2022
@asudoh
chore(devenv): simplify how to run React Storybook (#117)
94bda9a 
This change backs out some portion of #100, given React wrapper had to
be pre-built to run development mode of Storybook (for React). The
deployed (static) mode of Storybook still depends on pre-built version
of React wrapper, but it's OK as we can simply add it to the build
process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylam kennylam

Labels
bug Something isn't working dev Needs some dev work severity 2 Affects major functionality, has a workaround
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kennylam @jeffchew @RobertaJHahn @larahanlon2