Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer Logo inline-size is not applied: probably typo in SCSS #11730

Open
2 tasks done
ferrine opened this issue Apr 19, 2024 · 0 comments
Open
2 tasks done

Footer Logo inline-size is not applied: probably typo in SCSS #11730

ferrine opened this issue Apr 19, 2024 · 0 comments
Labels
bug Something isn't working dev Needs some dev work

Comments

@ferrine
Copy link

ferrine commented Apr 19, 2024

Description

inline-size

.#{$c4d-prefix}--footer-logo__link {
$logo-padding: math.div($grid-gutter, 2);
$logo-size: 8rem + ($logo-padding * 2);
display: inline-block;
color: $text-on-color;
inline-size: auto;
padding-inline-start: $logo-padding;
@include make-col-ready;

is overridden by

@mixin make-col-ready(
$gutter: $grid-gutter,
$condensed-gutter: $grid-gutter-condensed
) {
// Prevent columns from becoming too narrow when at smaller grid tiers by
// always setting `width: 100%;`. This works because we use `flex` values
// later on to override this initial width.
inline-size: 100%;

which does not seem to be intentional

Component(s) impacted

footer

Browser

Chrome

Carbon for IBM.com version

2.7.0

Severity

Severity 4 = The problem is not visible to or noticeable to an average user. Affects minor functionality, no workaround needed.

Application/website

stuff

Package

@carbon/ibmdotcom-web-components

CodeSandbox example

NA

Steps to reproduce the issue (if applicable)

NA

Release date (if applicable)

No response

Code of Conduct

@ferrine ferrine added bug Something isn't working dev Needs some dev work labels Apr 19, 2024
@ferrine ferrine changed the title [YOUR TITLE]: Footer Logo inline-size: probably typo in SCSS Apr 19, 2024
@ferrine ferrine changed the title Footer Logo inline-size: probably typo in SCSS Footer Logo inline-size is not applied: probably typo in SCSS Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work
Projects
Status: No status
Development

No branches or pull requests

1 participant