Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(checkbox): add shadow parts #11905

Merged
merged 4 commits into from
Jul 5, 2024
Merged

feat(checkbox): add shadow parts #11905

merged 4 commits into from
Jul 5, 2024

Conversation

marcelojcs
Copy link
Contributor

Related Ticket(s)

Jira

Description

All non-slot elements in the shadow DOM should be given a unique "part" name allowing CSS to target and override component default styles.

Changelog

adding shadow parts to the checkbox component

@marcelojcs marcelojcs requested a review from a team as a code owner July 3, 2024 20:27
@marcelojcs marcelojcs requested review from emyarod, sangeethababu9223, m4olivei, bruno-amorim and andy-blum and removed request for a team July 3, 2024 20:27
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 3, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11905/index.html

Built with commit: ca37219d1e837fb1e57b08e7bba52b9505367fe6

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 3, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11905/index.html

Built with commit: ca37219d1e837fb1e57b08e7bba52b9505367fe6

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 3, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11905/index.html

Built with commit: ca37219d1e837fb1e57b08e7bba52b9505367fe6

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 3, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11905/index.html

Built with commit: ca37219d1e837fb1e57b08e7bba52b9505367fe6

m4olivei
m4olivei requested changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look good. I just found a couple of places where we're still missing part attributes.

packages/carbon-web-components/src/components/checkbox/checkbox-group.ts Show resolved Hide resolved
packages/carbon-web-components/src/components/checkbox/checkbox.ts Show resolved Hide resolved
@m4olivei m4olivei merged commit 4a1e91f into carbon-design-system:feat/v2-shadow-parts Jul 5, 2024
10 of 20 checks passed
@m4olivei m4olivei deleted the checkbox-shadow-parts branch July 5, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4olivei m4olivei m4olivei requested changes

@bruno-amorim bruno-amorim Awaiting requested review from bruno-amorim

@andy-blum andy-blum Awaiting requested review from andy-blum

Assignees
No one assigned
Labels
shadow parts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelojcs @ibmdotcom-bot @m4olivei