Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop the modal w/ margins component #253

Closed
5 tasks
jeffchew opened this issue Oct 13, 2019 · 6 comments · Fixed by #575
Closed
5 tasks

Develop the modal w/ margins component #253

jeffchew opened this issue Oct 13, 2019 · 6 comments · Fixed by #575
Assignees
Labels
dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package sprint demo Sprint Must Have
Milestone

Comments

@jeffchew
Copy link
Member

jeffchew commented Oct 13, 2019

hahnrob created the following on Jun 20:

User Story

As a [user role below]:
As a developer using the Digital Design System

I need to:
have an Expressive Modal in the Locale Selector

so that I can:
include this component in the Locale Selector in the web site I am developing

Additional information

Acceptance criteria

  • Component has been tested using Netlify
  • The component development follows a modular component pattern
  • The component should be accessible via ES6 import
  • The component should be visible within the living documentation of the Dotcom components
  • Presented and approved Product Owner

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1078

@jeffchew jeffchew added dev Needs some dev work dotcom package: react Work necessary for the Carbon for IBM.com react components package Sprint Must Have labels Oct 13, 2019
@jeffchew jeffchew added this to the Sprint 20 milestone Oct 13, 2019
@jeffchew
Copy link
Member Author

On Aug 05, hahnrob commented:
T-shirt Sizing: Medium

@jeffchew
Copy link
Member Author

On Sep 10, james-dow commented:
I wanted to make sure I put this here for whoever ends up picking up this ticket. It's the APIs currently being used in v18 for the Locale selector.

@jeffchew
Copy link
Member Author

On Sep 17, hahnrob commented:
Avi's meeting notes from Sept 16 Locale Selector JS file:

Thanks to all of you for attending the call today.

The purpose of the call was to understand and discuss the current and future process/tool/owner for updating the locale selector JS file that it is used by ibm.com DDS team.

https://1.www.s81c.com/common/js/dynamicnav/www/countrylist/usen-utf8.js

This is the recap and key points:

  1. Originally, ECM/IConS was used to author and generate the locale selector JS file. After the sunset of ECM/IConS, the file gets updated manually whenever there is a change. Changes are not frequent.

  2. Updating the file is one small step in a multi-step process for adding/changing locales to Drupal/ibm.com

  3. Tina owns the list of locales and will coordinate with the web master/MSC teams whenever the file needs to be updated.

  4. A JSON format of the file is required for the new version of ibm.com design (Carbon). Once the new design is deployed, both JS and JSON files need to be updated and kept in synch.

Please let me know if I missed/misstated anything major.

Thanks!

Avi Rakhsha
Sr. Manager, Digital Content Platforms
avi_rakhsha@us.ibm.com

@jeffchew
Copy link
Member Author

On Oct 03, hahnrob commented:
Design review meetings conducted Oct 3.

@jeffchew
Copy link
Member Author

ButtonGroup work has been merged in to support this story: #545

@RobertaJHahn
Copy link

Presented in the Oct 28 Sprint Review meeting. Closing.

kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Mar 16, 2022
This change moves to GH actions for the CI env.
This change also adds Firefox unit test to the CI env.
The old CI setting file is kept intact until we can remove the GH app.
annawen1 pushed a commit that referenced this issue Sep 15, 2022
This change moves to GH actions for the CI env.
This change also adds Firefox unit test to the CI env.
The old CI setting file is kept intact until we can remove the GH app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package sprint demo Sprint Must Have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants