Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lightbox media viewer]: Change the functional specifications to include carousel functionality #6371

Closed
3 tasks
RobertaJHahn opened this issue Jun 15, 2021 · 2 comments
Assignees
Labels
adopter: AEM used when component or pattern will be used by this adopter adopter support ba Needs some business analyst work design Applied to all issues assigned to the design team members. Filter used in planning meetings Feature request A new adopter requested feature priority: medium
Milestone

Comments

@RobertaJHahn
Copy link

RobertaJHahn commented Jun 15, 2021

User Story

As a [user role below]:
DDS developer

I need to:
have the Lightbox media viewer functional specs

so that I can:
so that I can properly code the Lightbox media viewer component that meets the Design functions and intent

Additional information

PDF
Sketch file

Acceptance criteria

  • Documented Lightbox media viewer functional specifications
  • Sent and/or presented the specs to Design and Engineering for their review and comments
  • Comment is added with link to functional specs
@RobertaJHahn RobertaJHahn added adopter support adopter: AEM used when component or pattern will be used by this adopter ba Needs some business analyst work design Applied to all issues assigned to the design team members. Filter used in planning meetings priority: high Feature request A new adopter requested feature labels Jun 15, 2021
@photodow
Copy link
Contributor

photodow commented Jul 19, 2021

@shixiedesign
Copy link
Contributor

I know we usually present the FS to devs during a Epic refinement but I think we have a few more changes to Lightbox coming up. Suggest we present all the changes to lightbox together when those are done too. So closing this for now so the Milestone can be closed. I will make a note for the next Engineering refinement meeting.

kodiakhq bot pushed a commit that referenced this issue Jun 3, 2024
Bumps [axios](https://github.com/axios/axios) from 1.6.8 to 1.7.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p>
<blockquote>
<h2>Release v1.7.0</h2>
<h2>Release notes:</h2>
<h3>Features</h3>
<ul>
<li><strong>adapter:</strong> add fetch adapter; (<a href="https://redirect.github.com/axios/axios/issues/6371">#6371</a>) (<a href="https://github.com/axios/axios/commit/a3ff99b59d8ec2ab5dd049e68c043617a4072e42">a3ff99b</a>)</li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li><strong>core/axios:</strong> handle un-writable error stack (<a href="https://redirect.github.com/axios/axios/issues/6362">#6362</a>) (<a href="https://github.com/axios/axios/commit/81e0455b7b57fbaf2be16a73ebe0e6591cc6d8f9">81e0455</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+1015/-127 ([#6371](axios/axios#6371) )">Dmitriy Mozgovoy</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/jasonsaayman" title="+30/-14 ()">Jay</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/alexandre-abrioux" title="+56/-6 ([#6362](axios/axios#6362) )">Alexandre ABRIOUX</a></li>
</ul>
<h2>Release v1.7.0-beta.2</h2>
<h2>Release notes:</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>fetch:</strong> capitalize HTTP method names; (<a href="https://redirect.github.com/axios/axios/issues/6395">#6395</a>) (<a href="https://github.com/axios/axios/commit/ad3174a3515c3c2573f4bcb94818d582826f3914">ad3174a</a>)</li>
<li><strong>fetch:</strong> fix &amp; optimize progress capturing for cases when the request data has a nullish value or zero data length (<a href="https://redirect.github.com/axios/axios/issues/6400">#6400</a>) (<a href="https://github.com/axios/axios/commit/95a3e8e346cfd6a5548e171f2341df3235d0e26b">95a3e8e</a>)</li>
<li><strong>fetch:</strong> fix headers getting from a stream response; (<a href="https://redirect.github.com/axios/axios/issues/6401">#6401</a>) (<a href="https://github.com/axios/axios/commit/870e0a76f60d0094774a6a63fa606eec52a381af">870e0a7</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+99/-46 ([#6405](axios/axios#6405) [#6404](axios/axios#6404) [#6401](axios/axios#6401) [#6400](axios/axios#6400) [#6395](axios/axios#6395) )">Dmitriy Mozgovoy</a></li>
</ul>
<h2>Release v1.7.0-beta.1</h2>
<h2>Release notes:</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>core/axios:</strong> handle un-writable error stack (<a href="https://redirect.github.com/axios/axios/issues/6362">#6362</a>) (<a href="https://github.com/axios/axios/commit/81e0455b7b57fbaf2be16a73ebe0e6591cc6d8f9">81e0455</a>)</li>
<li><strong>fetch:</strong> fix cases when ReadableStream or Response.body are not available; (<a href="https://redirect.github.com/axios/axios/issues/6377">#6377</a>) (<a href="https://github.com/axios/axios/commit/d1d359da347704e8b28d768e61515a3e96c5b072">d1d359d</a>)</li>
<li><strong>fetch:</strong> treat fetch-related TypeError as an AxiosError.ERR_NETWORK error; (<a href="https://redirect.github.com/axios/axios/issues/6380">#6380</a>) (<a href="https://github.com/axios/axios/commit/bb5f9a5ab768452de9e166dc28d0ffc234245ef1">bb5f9a5</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a href="https://github.com/alexandre-abrioux" title="+56/-6 ([#6362](axios/axios#6362) )">Alexandre ABRIOUX</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+42/-17 ([#6380](axios/axios#6380) [#6377](axios/axios#6377) )">Dmitriy Mozgovoy</a></li>
</ul>
<h3>Install</h3>
<pre><code>npm i axios@next
</code></pre>
<h2>Release v1.7.0-beta.0</h2>
<h2>Release notes:</h2>
<h3>Features</h3>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's changelog</a>.</em></p>
<blockquote>
<h1><a href="https://github.com/axios/axios/compare/v1.7.0-beta.2...v1.7.0">1.7.0</a> (2024-05-19)</h1>
<h3>Features</h3>
<ul>
<li><strong>adapter:</strong> add fetch adapter; (<a href="https://redirect.github.com/axios/axios/issues/6371">#6371</a>) (<a href="https://github.com/axios/axios/commit/a3ff99b59d8ec2ab5dd049e68c043617a4072e42">a3ff99b</a>)</li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li><strong>core/axios:</strong> handle un-writable error stack (<a href="https://redirect.github.com/axios/axios/issues/6362">#6362</a>) (<a href="https://github.com/axios/axios/commit/81e0455b7b57fbaf2be16a73ebe0e6591cc6d8f9">81e0455</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+1015/-127 ([#6371](axios/axios#6371) )">Dmitriy Mozgovoy</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/jasonsaayman" title="+30/-14 ()">Jay</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/alexandre-abrioux" title="+56/-6 ([#6362](axios/axios#6362) )">Alexandre ABRIOUX</a></li>
</ul>
<h1><a href="https://github.com/axios/axios/compare/v1.7.0-beta.1...v1.7.0-beta.2">1.7.0-beta.2</a> (2024-05-19)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>fetch:</strong> capitalize HTTP method names; (<a href="https://redirect.github.com/axios/axios/issues/6395">#6395</a>) (<a href="https://github.com/axios/axios/commit/ad3174a3515c3c2573f4bcb94818d582826f3914">ad3174a</a>)</li>
<li><strong>fetch:</strong> fix &amp; optimize progress capturing for cases when the request data has a nullish value or zero data length (<a href="https://redirect.github.com/axios/axios/issues/6400">#6400</a>) (<a href="https://github.com/axios/axios/commit/95a3e8e346cfd6a5548e171f2341df3235d0e26b">95a3e8e</a>)</li>
<li><strong>fetch:</strong> fix headers getting from a stream response; (<a href="https://redirect.github.com/axios/axios/issues/6401">#6401</a>) (<a href="https://github.com/axios/axios/commit/870e0a76f60d0094774a6a63fa606eec52a381af">870e0a7</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+99/-46 ([#6405](axios/axios#6405) [#6404](axios/axios#6404) [#6401](axios/axios#6401) [#6400](axios/axios#6400) [#6395](axios/axios#6395) )">Dmitriy Mozgovoy</a></li>
</ul>
<h1><a href="https://github.com/axios/axios/compare/v1.7.0-beta.0...v1.7.0-beta.1">1.7.0-beta.1</a> (2024-05-07)</h1>
<h3>Bug Fixes</h3>
<ul>
<li><strong>core/axios:</strong> handle un-writable error stack (<a href="https://redirect.github.com/axios/axios/issues/6362">#6362</a>) (<a href="https://github.com/axios/axios/commit/81e0455b7b57fbaf2be16a73ebe0e6591cc6d8f9">81e0455</a>)</li>
<li><strong>fetch:</strong> fix cases when ReadableStream or Response.body are not available; (<a href="https://redirect.github.com/axios/axios/issues/6377">#6377</a>) (<a href="https://github.com/axios/axios/commit/d1d359da347704e8b28d768e61515a3e96c5b072">d1d359d</a>)</li>
<li><strong>fetch:</strong> treat fetch-related TypeError as an AxiosError.ERR_NETWORK error; (<a href="https://redirect.github.com/axios/axios/issues/6380">#6380</a>) (<a href="https://github.com/axios/axios/commit/bb5f9a5ab768452de9e166dc28d0ffc234245ef1">bb5f9a5</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a href="https://github.com/alexandre-abrioux" title="+56/-6 ([#6362](axios/axios#6362) )">Alexandre ABRIOUX</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+42/-17 ([#6380](axios/axios#6380) [#6377](axios/axios#6377) )">Dmitriy Mozgovoy</a></li>
</ul>
<h1><a href="https://github.com/axios/axios/compare/v1.6.8...v1.7.0-beta.0">1.7.0-beta.0</a> (2024-04-28)</h1>
<h3>Features</h3>
<ul>
<li><strong>adapter:</strong> add fetch adapter; (<a href="https://redirect.github.com/axios/axios/issues/6371">#6371</a>) (<a href="https://github.com/axios/axios/commit/a3ff99b59d8ec2ab5dd049e68c043617a4072e42">a3ff99b</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/axios/axios/commit/3041c61adaaac6d2c43eba28c134e7f4d43ab012"><code>3041c61</code></a> [Release] v1.7.0 (<a href="https://redirect.github.com/axios/axios/issues/6408">#6408</a>)</li>
<li><a href="https://github.com/axios/axios/commit/18b13cbaef66d8c266cf681165afe31787420100"><code>18b13cb</code></a> chore(docs): add fetch adapter docs; (<a href="https://redirect.github.com/axios/axios/issues/6407">#6407</a>)</li>
<li><a href="https://github.com/axios/axios/commit/e62099bc8b640acf47fba639366bbcd3bf87f831"><code>e62099b</code></a> fix(fetch): fixed a possible memory leak in the AbortController for the strea...</li>
<li><a href="https://github.com/axios/axios/commit/b49aa8e3d837c36e4728a9fa8a5e23a1162e96ec"><code>b49aa8e</code></a> chore(release): v1.7.0-beta.2 (<a href="https://redirect.github.com/axios/axios/issues/6403">#6403</a>)</li>
<li><a href="https://github.com/axios/axios/commit/d57f03a77fef1eb3cd9a17e2973c4305e105a42e"><code>d57f03a</code></a> chore(ci): bump create-pull-request version to fix a bug; (<a href="https://redirect.github.com/axios/axios/issues/6405">#6405</a>)</li>
<li><a href="https://github.com/axios/axios/commit/097b0d18e93d12c53b77741d6bfdc8a1fc11828b"><code>097b0d1</code></a> chore(ci): add tag resolution for npm releases based on package version; (<a href="https://redirect.github.com/axios/axios/issues/6404">#6404</a>)</li>
<li><a href="https://github.com/axios/axios/commit/870e0a76f60d0094774a6a63fa606eec52a381af"><code>870e0a7</code></a> fix(fetch): fix headers getting from a stream response; (<a href="https://redirect.github.com/axios/axios/issues/6401">#6401</a>)</li>
<li><a href="https://github.com/axios/axios/commit/95a3e8e346cfd6a5548e171f2341df3235d0e26b"><code>95a3e8e</code></a> fix(fetch): fix &amp; optimize progress capturing for cases when the request data...</li>
<li><a href="https://github.com/axios/axios/commit/ad3174a3515c3c2573f4bcb94818d582826f3914"><code>ad3174a</code></a> fix(fetch): capitalize HTTP method names; (<a href="https://redirect.github.com/axios/axios/issues/6395">#6395</a>)</li>
<li><a href="https://github.com/axios/axios/commit/b9f4848f8c4c7d53dbe1a1ee06e9b3604c2e56ac"><code>b9f4848</code></a> chore(release): v1.7.0-beta.1 (<a href="https://redirect.github.com/axios/axios/issues/6383">#6383</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/axios/axios/compare/v1.6.8...v1.7.0">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=axios&package-manager=npm_and_yarn&previous-version=1.6.8&new-version=1.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/network/alerts).

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: AEM used when component or pattern will be used by this adopter adopter support ba Needs some business analyst work design Applied to all issues assigned to the design team members. Filter used in planning meetings Feature request A new adopter requested feature priority: medium
Projects
None yet
Development

No branches or pull requests

3 participants