Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pictogram-item): add shadow parts #11847

Merged
merged 3 commits into from
Jun 13, 2024
Merged

feat(pictogram-item): add shadow parts #11847

merged 3 commits into from
Jun 13, 2024

Conversation

Valentin-Sorin-Nicolae
Copy link
Contributor

ADCMS-5172

Description

All non-slot elements in the shadow DOM should be given a unique "part" name allowing CSS to target and override component default styles. This is for the "pictogram-item" component.

Changelog

New

Adding the shadow parts for the "pictogram-item" component and documentation

@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae requested a review from a team as a code owner June 5, 2024 12:26
@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae requested review from IgnacioBecerra and sangeethababu9223 and removed request for a team June 5, 2024 12:26
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jun 5, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11847/index.html

Built with commit: 321f4abbc975305509ee5511f46ec098d94db70e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jun 5, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11847/index.html

Built with commit: 321f4abbc975305509ee5511f46ec098d94db70e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jun 5, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11847/index.html

Built with commit: 321f4abbc975305509ee5511f46ec098d94db70e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jun 5, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11847/index.html

Built with commit: 321f4abbc975305509ee5511f46ec098d94db70e

@Valentin-Sorin-Nicolae
Copy link
Contributor Author

This component doesn't have a storybook documentation.

m4olivei
m4olivei approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

This component doesn't have a storybook documentation.

That's fine, especially given this componet is deprecated.

@m4olivei m4olivei merged commit 80bed7e into carbon-design-system:feat/v2-shadow-parts Jun 13, 2024
13 of 20 checks passed
@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae deleted the pictogram-item-shadow-part branch June 18, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4olivei m4olivei m4olivei approved these changes

@bruno-amorim bruno-amorim Awaiting requested review from bruno-amorim

@jkaeser jkaeser Awaiting requested review from jkaeser

@marcelojcs marcelojcs Awaiting requested review from marcelojcs

@andy-blum andy-blum Awaiting requested review from andy-blum

Assignees
No one assigned
Labels
shadow parts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Valentin-Sorin-Nicolae @ibmdotcom-bot @m4olivei