Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-cta): prevent order of operations issues #11911

Merged
merged 4 commits into from
Jul 9, 2024
Merged

fix(text-cta): prevent order of operations issues #11911

merged 4 commits into from
Jul 9, 2024

Conversation

marcelojcs
Copy link
Contributor

Related Ticket(s)

Jira

Description

An issue where the CTA on cards with videos is not being populated on some pages is being caused by an order of operation issue where the element is making calls tho an event listener that is not yet defined.
This PR is to ensure the correct order of execution

Changelog

Changed
Added customElements.whenDefined() to the video mixin to make sure the event only triggers after all componets needed are loaded.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 8, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11911/index.html

Built with commit: c52a586e0166b484e25b09bfdcba31b39e0b68bd

@m4olivei m4olivei added the test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing label Jul 8, 2024
@m4olivei m4olivei closed this Jul 8, 2024
@m4olivei m4olivei reopened this Jul 8, 2024
@m4olivei m4olivei marked this pull request as ready for review July 8, 2024 14:09
@m4olivei m4olivei requested a review from a team as a code owner July 8, 2024 14:09
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 8, 2024 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/11911/index.html

Built with commit: c52a586e0166b484e25b09bfdcba31b39e0b68bd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 8, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11911/index.html

Built with commit: c52a586e0166b484e25b09bfdcba31b39e0b68bd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 8, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11911/index.html

Built with commit: c52a586e0166b484e25b09bfdcba31b39e0b68bd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 8, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11911/index.html

Built with commit: c52a586e0166b484e25b09bfdcba31b39e0b68bd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jul 8, 2024 •
edited
Loading

Deploy preview created for package IBM.com Web Components Deploy Preview CDN:
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11911/index.html

Built with commit: c52a586e0166b484e25b09bfdcba31b39e0b68bd

@m4olivei m4olivei added v1 bug Something isn't working owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants labels Jul 8, 2024
m4olivei
m4olivei approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me. Logically it makes sense. I've also tested on the reported pages using Requestly and the CDN links here, it works!

andy-blum
andy-blum approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@andy-blum andy-blum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified in codepen reproduction. Thanks!

https://codepen.io/andy-blum/pen/WNqbNKP/b4963942ffd9dcdc93c2d3a71a9eda85?editors=1010

@andy-blum andy-blum added the Ready to merge Label for the pull requests that are ready to merge label Jul 9, 2024
@kodiakhq kodiakhq bot merged commit bef93ea into carbon-design-system:v1 Jul 9, 2024
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4olivei m4olivei m4olivei approved these changes

@andy-blum andy-blum andy-blum approved these changes

@bruno-amorim bruno-amorim Awaiting requested review from bruno-amorim

Assignees
No one assigned
Labels
bug Something isn't working owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants Ready to merge Label for the pull requests that are ready to merge test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marcelojcs @ibmdotcom-bot @m4olivei @andy-blum