Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(content-item-horizontal): introduce eyebrow component #4842

Merged
merged 5 commits into from Jan 9, 2021
Merged

chore(content-item-horizontal): introduce eyebrow component #4842

merged 5 commits into from Jan 9, 2021

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Jan 7, 2021

Related Ticket(s)

Refs #4839.

Description

Introduces <dds-content-item-horizontal-eyebrow>.

Changelog

New

  • <dds-content-item-horizontal-eyebrow>

@asudoh
chore(content-item-horizontal): introduce eyebrow component
6669121 
Introduces `<dds-content-item-horizontal-eyebrow>`.

Refs carbon-design-system#4839.
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Jan 7, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 7, 2021 •
edited

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4842/index.html

Built with commit: 83b447fc8d34fb27f83d5c5cdcc0b92fba6f0c7a

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 7, 2021 •
edited

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4842/index.html

Built with commit: 83b447fc8d34fb27f83d5c5cdcc0b92fba6f0c7a

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 7, 2021 •
edited

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4842/index.html

Built with commit: 83b447fc8d34fb27f83d5c5cdcc0b92fba6f0c7a

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 8, 2021
jeffchew
jeffchew approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Remember to update the pinned issue with this breaking change.

@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jan 8, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the Ready to merge label.

@kodiakhq kodiakhq bot removed the Ready to merge Label for the pull requests that are ready to merge label Jan 8, 2021
@asudoh asudoh mentioned this pull request Jan 9, 2021
Closed
@asudoh asudoh added the Ready to merge Label for the pull requests that are ready to merge label Jan 9, 2021
@kodiakhq kodiakhq bot merged commit a479a6d into carbon-design-system:master Jan 9, 2021
@asudoh asudoh deleted the content-item-eyebrow branch January 9, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchew jeffchew jeffchew approved these changes

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asudoh @ibmdotcom-bot @jeffchew