Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use API from @carbon/icon-helpers #4

Closed
metonym opened this issue Dec 13, 2019 · 1 comment
Closed

refactor: use API from @carbon/icon-helpers #4

metonym opened this issue Dec 13, 2019 · 1 comment
Assignees
@metonym

Comments

@metonym
Copy link
Collaborator

metonym commented Dec 13, 2019 •
edited

@carbon/icon-helpers API

Pros

  • Using formatAttributes would reduce redundant code
  • Using toString with the content descriptors would eliminate createElements.ts

Cons

  • Using getAttributes at runtime would introduce @carbon/icon-helpers as a dependency
@metonym metonym changed the title refactor: utilize getAttributes, toString from @carbon/icon-helpers refactor: use API from @carbon/icon-helpers Dec 13, 2019
@metonym metonym self-assigned this Dec 13, 2019
metonym pushed a commit that referenced this issue Dec 13, 2019
feat(create-component): use formatAttributes from icon-helpers
99dd286 
Supports #4.

Breaking changes:

- remove width, height exports
metonym pushed a commit that referenced this issue Dec 13, 2019
feat(create-component): use toString to create elements
e4b027e 
Supports #4.
@metonym
Copy link
Collaborator Author

metonym commented Dec 13, 2019 •
edited

@cal-smith I want to refrain from using getAttributes as a runtime dependency; still investigating using it as a build-time dependency.

EDIT: Decided not to use getAttributes.

@metonym metonym closed this as completed Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metonym metonym

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@metonym