feat(chat): slotting and streaming #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-updates' into feat/chat-storybook-updates
fix(charts): fix some ts errors
✅ Deploy Preview for carbon-labs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
annawen1
reviewed
Apr 30, 2024
annawen1
reviewed
Apr 30, 2024
packages/chat/package.json
Outdated
| ], | ||
| "types": "./src/index.d.ts", | ||
| "customElements": "custom-elements.json", | ||
| "scripts": { | ||
| "build": "gulp build --option chat", | ||
| "build": "gulp build --option feedback", |
There was a problem hiding this comment.
please change back, otherwise it is not building the chat package
annawen1
reviewed
Apr 30, 2024
tsconfig.json
Outdated
| @@ -27,5 +27,5 @@ | |||
| "types": ["mocha", "sinon"] | |||
| }, | |||
| "include": ["packages/**/*.ts", ".storybook/**/*.ts", "declarations.d.ts"], | |||
| "exclude": ["packages/**/__tests__"] | |||
| "exclude": ["packages/**/__tests__","node_modules/vega-lite"] | |||
There was a problem hiding this comment.
I don't think we need to add the vega-lite here, it doesn't work
annawen1
reviewed
Apr 30, 2024
packages/chat/package.json
Outdated
| "build:dist": "rm -rf dist && rollup --config ../../tools/rollup.config.dist.js", | ||
| "build:dist:canary": "rm -rf dist && rollup --config ../../tools/rollup.config.dist.js --configCanary", | ||
| "postinstall": "ibmtelemetry --config=telemetry.yml" |
There was a problem hiding this comment.
please add the postinstall script back, it's needed for telemetry to work
annawen1
reviewed
Apr 30, 2024
| find . -type f -name '*.scss' -exec sed -i '' "s|${OLD_TOKEN}|${NEW_TOKEN}|g" {} + | ||
| done | ||
|
|
||
| echo “All .scss files updated” |
There was a problem hiding this comment.
I removed this last time because I'm not sure this script should live here
annawen1
reviewed
Apr 30, 2024
…g' into slottingandstreaming
annawen1
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
{{short description}}
Changelog
New
Changed
Removed
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}