Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook): generate custom-elements.json for storybook argstable #160

Merged

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented May 10, 2024

Closes #

This PR generates the custom-elements.json file needed to populate the ArgTypes table in storybook. The @element descriptor needs to be added to the JSDoc of the defined element which then gets picked up by custom-element-manifest/analyzer and generates the json file.

The yarn custom-elements script added to package.json and to the build command

Copy link

netlify bot commented May 10, 2024

Deploy Preview for carbon-labs ready!

Name Link
🔨 Latest commit 5283c3b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-labs/deploys/663e6c3e00e3a10008313151
😎 Deploy Preview https://deploy-preview-160--carbon-labs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@annawen1 annawen1 marked this pull request as ready for review May 10, 2024 18:50
@annawen1 annawen1 merged commit 303be38 into carbon-design-system:main May 10, 2024
9 checks passed
@annawen1 annawen1 deleted the chore/custom-elements-storybook branch May 10, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant