-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/chat storybook updates #95
Feat/chat storybook updates #95
Conversation
✅ Deploy Preview for carbon-labs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* | ||
* @returns {TemplateResult<1>} | ||
*/ | ||
render: () => html` <c4ai--chat-header> </c4ai--chat-header>`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just noticed we should not being using 2 hyphens for the component names, let's keep it consistent with one.
The classnames for the styles use 2 hyphens
render: () => html` <c4ai--chat-header> </c4ai--chat-header>`, | |
render: () => html` <c4ai-chat-header> </c4ai-chat-header>`, |
/** | ||
* Constructed class functionality for the test input custom element | ||
*/ | ||
@customElement(`${c4aiPrefix}--chat-header`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@customElement(`${c4aiPrefix}--chat-header`) | |
@customElement(`${c4aiPrefix}-chat-header`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs changes for sure, but we can revisit afterwards
Closes #
{{short description}}
Changelog
New
Changed
Removed
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}