feat(mdx-components): add footer and common js for ibm compliance #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❗ The commits in this PR will result in the following version changes: 🌟 MINOR release: |
|
|
@jdharvey-ibm any idea why this is failing, does it matter for this storybook update? 😅 |
@alisonjoseph LOL this is the age old "static build hit the GH rate limit" issue. But yeah, you're right that for the storybook update, we can safely ignore this. |
|
andreancardona
approved these changes
Feb 27, 2024
|
@jdharvey-ibm @francinelucca you ok with merging? |
jdharvey-ibm
approved these changes
Feb 28, 2024
|
@alisonjoseph Yeah! Go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes carbon-design-system/carbon#15637
Closes carbon-design-system/carbon#15652
Changelog
New
Testing / reviewing
run mdx-components storybook and verify footer is displaying correctly and common.js is being loaded