New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web-app): fix page not found vertical spacing #1779

Merged

francinelucca merged 2 commits into main from fix/page-not-found-styling

Mar 14, 2024

Member

francinelucca commented Mar 6, 2024 •

edited

Loading

Closes #1778

Changelog

Changed

Added css styling to fix vertical spacing in page not found component
Minor HTML restructure changes in page not found component

Testing / reviewing

Verify vertical spacing in lg/sm breakpoints:


          fix(web-app): fix page not found vertical spacing

655e8d3

francinelucca requested review from alisonjoseph and andreancardona as code owners

March 6, 2024 22:57

francinelucca added the status: ready for review 👀 label

francinelucca requested a review from mattrosno

March 6, 2024 22:57

Member

mattrosno commented Mar 6, 2024

Thanks @francinelucca!

@aagonzales @kingtraceyj can you review the screenshots here? Should there be space between the two sentences? Or should there just be space around the copy block like here: #1778

mattrosno requested review from aagonzales and kingtraceyj

March 6, 2024 23:01

Member

mattrosno commented Mar 13, 2024

Design guidance here: https://ibm-studios.slack.com/archives/C06P07KPAUR/p1709913167917949


          fix: page not found styling

898a136

Contributor

carbon-bot commented Mar 13, 2024

❗ The commits in this PR will result in the following version changes:

🐛 PATCH release: @carbon-platform/web-app

sonarcloud bot commented Mar 13, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Member Author

francinelucca commented Mar 13, 2024

Ready for re-rev

aagonzales approved these changes

View reviewed changes

Member

aagonzales left a comment

Looks good

mattrosno approved these changes

View reviewed changes

francinelucca enabled auto-merge

March 14, 2024 19:45

francinelucca added status: ready to merge 🎉 and removed status: ready for review 👀 labels

andreancardona approved these changes

View reviewed changes

francinelucca merged commit 59cbb98 into main

7 checks passed

francinelucca deleted the fix/page-not-found-styling branch

March 14, 2024 19:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mattrosno mattrosno approved these changes

aagonzales aagonzales approved these changes

andreancardona andreancardona approved these changes

alisonjoseph Awaiting requested review from alisonjoseph alisonjoseph is a code owner

kingtraceyj Awaiting requested review from kingtraceyj