This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
fix(button): prevent event propagation to children of disabled buttons #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-blum
requested review from
BrunnoM7,
annawen1 and
skuruvil
and removed request for
a team
|
cc: @kennylam |
|
Deploy preview created for Built with commit: d897f0cbdc0064a51f63f52ae892aa5888d1998f |
|
Deploy preview created for Built with commit: d897f0cbdc0064a51f63f52ae892aa5888d1998f |
|
Deploy preview created for Built with commit: d897f0cbdc0064a51f63f52ae892aa5888d1998f |
kennylam
added
the
Ready to merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Fixes #693
Description
Adds a
hostlistenerto the button component that uses thecapturephase to prevent click propagation to child elementsChangelog
Changed
disabledbuttons prevent click propagation to their child elements