Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

fix(deploy): properly deploy when a new tag is created #721

Merged
merged 1 commit into from
Oct 29, 2021
Merged

fix(deploy): properly deploy when a new tag is created #721

merged 1 commit into from
Oct 29, 2021

Conversation

jeffchew
Copy link
Member

Related Ticket(s)

No related issue

Description

This will properly deploy the storybook instance when there is a new tag created rather than by push.

Changelog

Changed

  • deploy.yml

@jeffchew jeffchew requested a review from a team as a code owner October 29, 2021 14:57
@jeffchew jeffchew requested review from ariellalgilmore, IgnacioBecerra and DragosRistici and removed request for a team October 29, 2021 14:57
@jeffchew jeffchew self-assigned this Oct 29, 2021
@jeffchew jeffchew added the dev Needs some dev work label Oct 29, 2021
@jeffchew jeffchew added this to the Sprint 21-22 milestone Oct 29, 2021
emyarod
emyarod approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Oct 29, 2021
@emyarod emyarod mentioned this pull request Oct 29, 2021
Closed
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/721/index.html

Built with commit: b3d9fa2046338a31d7e5d0256ae39d75252c2fac

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/721/index.html

Built with commit: b3d9fa2046338a31d7e5d0256ae39d75252c2fac

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/721/index.html

Built with commit: b3d9fa2046338a31d7e5d0256ae39d75252c2fac

@jeffchew jeffchew merged commit 26181d3 into carbon-design-system:master Oct 29, 2021
@jeffchew jeffchew deleted the fix/deploy-workflow branch October 29, 2021 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emyarod emyarod emyarod approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@DragosRistici DragosRistici Awaiting requested review from DragosRistici DragosRistici was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees

@jeffchew jeffchew

Labels
dev Needs some dev work hacktoberfest-accepted Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
Sprint 21-22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeffchew @ibmdotcom-bot @emyarod