Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link: Usage tab #3537

Closed
8 tasks done
Tracked by #13521
thyhmdo opened this issue May 8, 2023 · 3 comments
Closed
8 tasks done
Tracked by #13521

Link: Usage tab #3537

thyhmdo opened this issue May 8, 2023 · 3 comments

Comments

@thyhmdo
Copy link
Member

thyhmdo commented May 8, 2023

Ref discussion: carbon-design-system/carbon#15175
Ref boxnote: Usage tab pdf

Usage tab

  • Description: Possibly reword this sentence if needed to describe different use cases. Should we cover those here? Are we covering all of them currently?
  • Overview section: When not to use: Reword this paragraph to be more clear. Gower has commented on this in his PDF.
  • Anatomy section: In image: Change "Learn more" to something like "View docs".
Screen Shot 2023-05-15 at 4 51 34 PM
  • Content:

  • Clarify that we recommend labels accurately reflect the content users will find at the link destination. This may not always be possible.

  • "For further content guidance, see IBM Accessibility on link purpose." Revise this to link to the Accessibility tab for more information

  • Interactions section: Remove Screen reader parts.

  • Standalone link section:

  • Change sentence to this "Standalone links are the default link style for Carbon and only have an underline on hover and focus states."

  • Change the image to have different link content. For example, say something like "View docs" with a right arrow icon.

Screen Shot 2023-05-15 at 5 06 50 PM
  • Visited style section: Is it an accessibility violation to not use visited link styles? If you are not using visited styles, is there a known accessibility consideration that could be put in place? Ask Gower.

  • Add somewhere what our stance is on not allowing full images as pure links, but that it is okay to have an image within a card + text as a link, etc.


Answered questions from a11y discussion

Is a link made up of text + icon really a link, or is it a button?
A link is a link, not a button, regardless if it is just text or text + icon. We need to be clearer about the content we use as examples in our react storybook and website guidance to establish this.

In-page anchor links are violating the guidance for link color and icon placement.
The anchor links on the Carbon website are coming from Gatsby, not our core components. That being said, we should at least provide an underline on hover and focus in Gatsby. This will be a separate issue.

What about links that are just images?
We do not recommend using pure images as links. We have seen use cases of having cards that also include blocks on content within the container below the image treated as a link. We can add more about this in our guidance.

@oliviaflory
Copy link
Contributor

Examples of link + icon in IBM.com

CTA component

Within the CTA component in Carbon for Dotcom, we pull in the link with icon and pre-populate the following options:
Storybook link

  • Local: arrow-right
  • Anchor: arrow-down
  • External: launch
  • New tab: new-tab
  • Download: download
  • PDF: document-pdf
  • Blog: blog
  • Email: email
  • Call: phone
  • Schedule: calendar
  • Chat: chat

Outside of local, anchor, and external, the above have been requested from adopters to utilize in various pages.


Live examples

What is AI

Screenshot 2023-05-15 at 3 50 28 PM

API Connect

Screenshot 2023-05-15 at 3 53 56 PM
  • Note this example will likely transition to utilize the updated card specs
Screenshot 2023-05-16 at 9 35 00 AM

FlashSystem

  • Examples throughout their many pages
Screenshot 2023-05-16 at 9 36 03 AM Screenshot 2023-05-16 at 9 36 31 AM Screenshot 2023-05-16 at 9 37 08 AM

@sstrubberg sstrubberg modified the milestones: 2023 Q3, 2023 Q4 Sep 19, 2023
@sstrubberg sstrubberg added this to the 2024 Q1 milestone Oct 2, 2023
@laurenmrice
Copy link
Member

Related: #3869

@thyhmdo
Copy link
Member Author

thyhmdo commented Jan 25, 2024

Moving forward with new updates but there are two Unresolved issues after discussing this with @mbgower and the Design team:

1. Visited vs Unvisited link
Michael thinks that WCAG lacks clear guidance on distinguishing between visited and unvisited links, which they see as a failure in addressing the use of color to convey information. He submitted a pull request (PR) last summer to address this issue, but it seems that the proposed change has not been incorporated into the guidance yet. They provide a link to the merged but unpublished change that they had suggested. https://github.com/w3c/wcag/pull/3222/files

---> We may want to keep this the same in the guidance as an option until there's an update on their side


2. Underline or no underlines for all links
This seems like an issue to enforce the default links on products. We spotted the inconsistency of how Links are often used with Ghost buttons and it's hard to distinguish them when they appear closely on the same page or at the same position.

On the Accessibility side, It’s possible to distinguish links by colour, if the contrast is strong enough by G183: Using a contrast ratio of 3:1 with surrounding text and providing additional visual cues on focus for links or controls where color alone is used to identify them. For dangers of a colour-only approach, see the failure technique F73: Failure of Success Criterion 1.4.1 due to creating links that are not visually evident without color vision

---> We will need to add an underline for the focus state but probably leave the default Standalone link as they are at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

No branches or pull requests

4 participants