-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add StorybookDemo component #3716
feat: add StorybookDemo component #3716
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We originally designed the component in platform with the fluid dropdowns. Would it possible to update to the fluid dropdowns?
Contained list—update to 8 column small demo window
Popover looks a little wild—can we control the alignment? If so, I can do some mockups. I'm just a little unsure of how much control we have over storybook.
The combined dropdown/multiselect/combobox makes sense to me!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates. looks good to go! i'll discuss the popover story with the design team and will open another issue if we think it needs an update. thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome 💪🏻 🔥
Closes #3709
Changelog
New
StorybookDemo
componentChanged
ComponentDemo
withStorybookDemo
on all code and usage pages for components (used what we indexed for Carbon Next for 99% of components)Removed
Note: I didn't remove the
ComponentDemo
component,ChartDemoGroup
is relying on part of it.Review
Check component Usage/Code pages for correct demos
https://carbondesignsystem-git-fork-alisonj-f527c4-carbon-design-system.vercel.app/components/accordion/code