Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add StorybookDemo component #3716

Merged

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Aug 29, 2023

Closes #3709

Changelog

New

  • Add StorybookDemo component

Changed

  • Replace ComponentDemo with StorybookDemo on all code and usage pages for components (used what we indexed for Carbon Next for 99% of components)
  • Combined dropdown/multiselect/combobox into one demo, is that ok?

Removed

  • Remove custom ComponentDemo components

Note: I didn't remove the ComponentDemo component, ChartDemoGroup is relying on part of it.

Review

Check component Usage/Code pages for correct demos
https://carbondesignsystem-git-fork-alisonj-f527c4-carbon-design-system.vercel.app/components/accordion/code

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ❌ Failed (Inspect) Aug 31, 2023 5:22pm

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

Copy link
Member

@kingtraceyj kingtraceyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We originally designed the component in platform with the fluid dropdowns. Would it possible to update to the fluid dropdowns?

Contained list—update to 8 column small demo window

Popover looks a little wild—can we control the alignment? If so, I can do some mockups. I'm just a little unsure of how much control we have over storybook.
image

The combined dropdown/multiselect/combobox makes sense to me!

@alisonjoseph
Copy link
Member Author

alisonjoseph commented Aug 29, 2023

@kingtraceyj

  • For Popover - Any changes to the story content would need to be done in storybook. It's currently set up to show how popover will align automatically based on where on the screen it is.
    https://react.carbondesignsystem.com/?path=/story/components-popover--auto-align
    If there is a better way to display this auto-align feature we can update in Storybook and it will automatically update on the website when the story updates. You can create an issue and tag me if you want.
  • Updated to use FluidDropdown
  • Just pushed a change to contained list to 8 column

Copy link
Member

@kingtraceyj kingtraceyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates. looks good to go! i'll discuss the popover story with the design team and will open another issue if we think it needs an update. thank you!

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome 💪🏻 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace live demo with storybook live demo from platform
4 participants