-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs (dropdown): Select all functionality for usage and a11y tabs #4026
base: main
Are you sure you want to change the base?
Docs (dropdown): Select all functionality for usage and a11y tabs #4026
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DCO Assistant Lite bot: Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Images
There are just a couple of things that need to be adjusted in the images and I have made more in depth comments around this in your Figma file.
For some of the comments below, I created a change inline with your markdown, so if you hit the "commit suggestion" button, it will commit it for you and you won't have to manually make the change yourself in vscode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
the keys for opening the component and selecting its options are different for | ||
each variant. | ||
[Learn more about these accessibility considerations here](https://carbondesignsystem.com/components/dropdown/accessibility/?_ga=2.84465055.789214944.1712051588-758524008.1712051588&_gl=1*16jmo7x*_ga*NzU4NTI0MDA4LjE3MTIwNTE1ODg.*_ga_FYECCCS21D*MTcxMjEzODc0OC4zLjEuMTcxMjE0MTQ5OC4wLjAuMA..#what-carbon-provides) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is long for a link. We have a few examples:
- For more information on tag states, see the style tab.
- For further content guidance, see Carbon’s content guidelines.
I guess we can do something similar
- For more information on keyboard interactions, see the accessibility tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thyhmdo - have corrected this. please check the updated commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
🙌
Closes #3977 #3973
Usage Document for Dropdown component on the website as part of the multiselect-select all functionality has been updated
Changelog
New
Changed
Removed