Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs (dropdown): Select all functionality for usage and a11y tabs #4026

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

benjamin-kurien
Copy link

@benjamin-kurien benjamin-kurien commented Apr 16, 2024

Closes #3977 #3973

Usage Document for Dropdown component on the website as part of the multiselect-select all functionality has been updated

Changelog

New

  • Anatomy: Introduced an element, named it as parent checkbox. Updated image.
  • Content, Main elements: Explained the language for parent checkbox, added an image to explain.
  • Multiselect Variant: Explained the functionality for selecting all, indeterminate states. Added an image to explain further.

Changed

  • Images updated: Anatomy section, Accessibility section.
  • Heading added: "Feedback" added as a header within multiselect variant.
  • Explanation added: Content section, multiselect variant.

Removed

  • Keyboard interactions removed from usage tab.

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 2:12pm

Copy link
Contributor

DCO Assistant Lite bot: Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


You can retrigger this bot by commenting recheck in this Pull Request

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images
There are just a couple of things that need to be adjusted in the images and I have made more in depth comments around this in your Figma file.

For some of the comments below, I created a change inline with your markdown, so if you hit the "commit suggestion" button, it will commit it for you and you won't have to manually make the change yourself in vscode.

src/pages/components/dropdown/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/dropdown/usage.mdx Outdated Show resolved Hide resolved
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@benjamin-kurien benjamin-kurien changed the title Docs (dropdown): Select all functionality Docs (dropdown): Select all functionality for usage and a11y tabs Apr 19, 2024
the keys for opening the component and selecting its options are different for
each variant.
[Learn more about these accessibility considerations here](https://carbondesignsystem.com/components/dropdown/accessibility/?_ga=2.84465055.789214944.1712051588-758524008.1712051588&_gl=1*16jmo7x*_ga*NzU4NTI0MDA4LjE3MTIwNTE1ODg.*_ga_FYECCCS21D*MTcxMjEzODc0OC4zLjEuMTcxMjE0MTQ5OC4wLjAuMA..#what-carbon-provides)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is long for a link. We have a few examples:

I guess we can do something similar

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thyhmdo - have corrected this. please check the updated commit.

Copy link
Member

@thyhmdo thyhmdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiSelect (select all option): create usage content
4 participants