Incorrect reference to Figma property #4152
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The caption referenced "Auto Width" when the example was showing "Auto Height". I switched the text to say "Auto Height". I also fixed a few grammatically incorrect phrases in similar captions
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
DCO Assistant Lite bot: Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request |
laurenmrice
reviewed
Jul 2, 2024
| @@ -400,9 +400,9 @@ it to the top or bottom margin of a box: | |||
|
|
|||
| </DoDont> | |||
|
|
|||
| <DoDont type="dont" caption="In Figma, always use “Auto width” in the Text panel to ensure the text box is fitting with the content. Spacer snaps to the text box."> | |||
| <DoDont type="dont" caption="In Figma, always use “Auto Height” in the Text panel to ensure the text box fits with the content. Spacer snaps to the text box."> | |||
There was a problem hiding this comment.
Suggested change
| <DoDont type="dont" caption="In Figma, always use “Auto Height” in the Text panel to ensure the text box fits with the content. Spacer snaps to the text box."> | |
| <DoDont type="dont" caption="In Figma, always use “Auto height” in the Text panel to ensure the text box fits with the content. Spacer snaps to the text box."> |
Nice catch @chadcwimberly. Just suggesting this be in sentence case instead of title case like it is in Figma.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caption referenced "Auto Width" when the example was showing "Auto Height". I switched the text to say "Auto Height". I also fixed a few grammatically incorrect phrases in similar captions
Closes #
{{short description}}
Changelog
New
Changed
Removed