Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Added Uploading to experimental and nav #474

Closed
wants to merge 2 commits into from

Conversation

Solly2
Copy link

@Solly2 Solly2 commented Oct 9, 2019

Added an additional page to the Experimental section of the site named "Uploading" with our uploading pattern, with bulk uploading included within it.

I've also added Uploading to the navigation system.

@vercel
Copy link

vercel bot commented Oct 9, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/carbon-design-system/carbon-website/31s0n36d2
🌍 Preview: https://carbon-website-git-fork-solly2-bulk-upload.carbon-design-system.now.sh


<ImageComponent cols="8">

![Contextual image](images/1.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented about this on your other PR, but we want to use more detailed alt text for visually impaired readers using screen readers.


### Transferring a resource from a local system to a remote system.

<ImageComponent cols="8">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ImageComponent cols="8">
<Row>
<Column colLg={8}>

The <ImageComponent> was deprecated with the release of our Gatsby theme. You can now just place the image in an 8 column wrapper. This docs site has more detail about the new components: https://gatsby-theme-carbon.now.sh/components/markdown#images


![Contextual image](images/1.png)

</ImageComponent>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</ImageComponent>
</Column>
</Row>


## Things to consider

- Is the action uploading or is it importing?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Is the action uploading or is it importing?
- Is the action uploading or is it [importing](/experimental/import-pattern)?


- Is the action uploading or is it importing?
- Where is the upload action performed?
- How many items will the user need to upload at any one time? The UI shell is designed to be configurable. A product or platform can choose which shell components and configurations to use, based on their user and information requirements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- How many items will the user need to upload at any one time? The UI shell is designed to be configurable. A product or platform can choose which shell components and configurations to use, based on their user and information requirements.
- How many items will the user need to upload at any one time? The [UI shell](/components/UI-shell-header/usage) is designed to be configurable. A product or platform can choose which shell components and configurations to use based on their user and information requirements.


## Overview

The action of uploading should always be the result of a user action.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The action of uploading should always be the result of a user action.
Uploading should always be the result of a user action.

## Overview

The action of uploading should always be the result of a user action.
The action of uploading a file could be done by selecting an action button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The action of uploading a file could be done by selecting an action button
Uploading a file can be done by selecting an action button

I wonder why the text wraps onto a new line like this. Was this intentional?

Co-Authored-By: Connor <connor@ibm.com>
@connor-leech
Copy link
Contributor

New experimental content will be accepted via an upcoming submission platform as roughly detailed here: https://app.zenhub.com/workspaces/carbon-design-system-593830641344b813db10934d/issues/carbon-design-system/carbon/4869

I've touched base with @vikkipaterson about working together on shaping that in the new year. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Carbon support
  
PR: needs review 🕵️
Development

Successfully merging this pull request may close these issues.

None yet

2 participants