Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use InlineNotification's in all tutorials #889

Merged
merged 4 commits into from Feb 12, 2020
Merged

docs: use InlineNotification's in all tutorials #889

merged 4 commits into from Feb 12, 2020

Conversation

mattrosno
Copy link
Member

No description provided.

@mattrosno mattrosno requested review from a team February 10, 2020 17:44
@mattrosno mattrosno requested a review from a team as a code owner February 10, 2020 17:44
@mattrosno mattrosno requested review from janchild, sstrubberg and andreancardona and removed request for a team February 10, 2020 17:44
@vercel
Copy link

vercel bot commented Feb 10, 2020 •
edited

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/carbon-design-system/carbon-website/hrdwrnyd5
✅ Preview: https://carbon-website-git-fork-mattrosno-tutorial-cleanup.carbon-design-system.now.sh

@ghost ghost requested review from asudoh and joshblack and removed request for a team February 10, 2020 17:44
@mattrosno
Copy link
Member Author

@lee-chase @cal-smith I cleaned up all of the tutorial notes and pro tips as InlineNotifications. Can you review your tutorials to make sure everything still looks good?

cal-smith
cal-smith approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@cal-smith cal-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me!

@janchild janchild requested review from connor-leech and removed request for janchild February 10, 2020 19:27
@connor-leech connor-leech merged commit a2abc45 into carbon-design-system:master Feb 12, 2020
@lee-chase
Copy link
Member

@mattrosno one thing that does look more off than before is the code snippets and images busting out of the column used for the other text content.

@mattrosno
Copy link
Member Author

@lee-chase I agree, code snippet hangs into the gutter and the InlineNotification does not, giving this a jarring/jagged effect. I'll open an issue in the Gatsby theme to see if this is working as intended.

image

natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@mattrosno @vpicone @natashadecoste
docs: use InlineNotification's in all tutorials (carbon-design-system…
9ac139c 
…#889)

* docs: format tutorial notes as InlineNotification's

- pro tips too

* docs: add InlineNotification's to angular and vue tutorial

Co-authored-by: Vince Picone <vpicone@gmail.com>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@mattrosno @vpicone @natashadecoste
docs: use InlineNotification's in all tutorials (carbon-design-system…
ec031cb 
…#889)

* docs: format tutorial notes as InlineNotification's

- pro tips too

* docs: add InlineNotification's to angular and vue tutorial

Co-authored-by: Vince Picone <vpicone@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cal-smith cal-smith cal-smith approved these changes

@vpicone vpicone vpicone approved these changes

@connor-leech connor-leech connor-leech approved these changes

@sstrubberg sstrubberg Awaiting requested review from sstrubberg

@andreancardona andreancardona Awaiting requested review from andreancardona

@asudoh asudoh Awaiting requested review from asudoh

@joshblack joshblack Awaiting requested review from joshblack

@lee-chase lee-chase Awaiting requested review from lee-chase

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mattrosno @lee-chase @cal-smith @vpicone @connor-leech