fix(dataTable): search accessibility issue (#7359)

* fix(dataTable): search accessibility issue * Removed Aria-hidden. * chore: update snapshots Co-authored-by: Cassidy Jensen <Cassidy.Jensen@ibm.com> Co-authored-by: emyarod <afw5059@gmail.com> Co-authored-by: TJ Egan <tw15egan@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
carbon-design-system · Dec 7, 2020 · 38b009b · 38b009b
1 parent 56282c6
commit 38b009b
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 7 deletions.
diff --git a/packages/react/src/components/DataTable/TableToolbarSearch.js b/packages/react/src/components/DataTable/TableToolbarSearch.js
@@ -118,7 +118,6 @@ const TableToolbarSearch = ({
         className={className}
         value={value}
         id={typeof id !== 'undefined' ? id : uniqueId.toString()}
-        aria-hidden={!searchExpanded}
         labelText={labelText || t('carbon.table.toolbar.search.label')}
         placeHolderText={
           placeHolderText || t('carbon.table.toolbar.search.placeholder')

diff --git a/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap b/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
@@ -2295,7 +2295,6 @@ exports[`DataTable should render 1`] = `
                   tabIndex="-1"
                 >
                   <Search
-                    aria-hidden={false}
                     closeButtonLabelText="Clear search input"
                     id="custom-id"
                     labelText="Filter table"
@@ -2348,7 +2347,6 @@ exports[`DataTable should render 1`] = `
                         Filter table
                       </label>
                       <input
-                        aria-hidden={false}
                         autoComplete="off"
                         className="bx--search-input"
                         id="custom-id"
@@ -3303,7 +3301,6 @@ exports[`DataTable sticky header should render 1`] = `
                   tabIndex="-1"
                 >
                   <Search
-                    aria-hidden={false}
                     closeButtonLabelText="Clear search input"
                     id="custom-id"
                     labelText="Filter table"
@@ -3356,7 +3353,6 @@ exports[`DataTable sticky header should render 1`] = `
                         Filter table
                       </label>
                       <input
-                        aria-hidden={false}
                         autoComplete="off"
                         className="bx--search-input"
                         id="custom-id"

diff --git a/...es/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarSearch-test.js.snap b/...es/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarSearch-test.js.snap
@@ -18,7 +18,6 @@ exports[`DataTable.TableToolbarSearch should render 1`] = `
     tabIndex="0"
   >
     <Search
-      aria-hidden={true}
       className="custom-class"
       closeButtonLabelText="Clear search input"
       id="custom-id"
@@ -72,7 +71,6 @@ exports[`DataTable.TableToolbarSearch should render 1`] = `
           Filter table
         </label>
         <input
-          aria-hidden={true}
           autoComplete="off"
           className="bx--search-input"
           id="custom-id"