Skip to content

Commit

Permalink
fix(RadioButton): remove unecessary aria-label (#4678)
Browse files Browse the repository at this point in the history
  • Loading branch information
dakahn authored and asudoh committed Nov 16, 2019
1 parent cc362ff commit 77d8363
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,6 @@ exports[`DataTable selection -- radio buttons should render 1`] = `
value=""
/>
<label
aria-label="Select row"
className="bx--radio-button__label"
htmlFor="data-table-14__select-row-b"
>
Expand Down Expand Up @@ -655,7 +654,6 @@ exports[`DataTable selection -- radio buttons should render 1`] = `
value=""
/>
<label
aria-label="Select row"
className="bx--radio-button__label"
htmlFor="data-table-14__select-row-a"
>
Expand Down Expand Up @@ -742,7 +740,6 @@ exports[`DataTable selection -- radio buttons should render 1`] = `
value=""
/>
<label
aria-label="Select row"
className="bx--radio-button__label"
htmlFor="data-table-14__select-row-c"
>
Expand Down
5 changes: 1 addition & 4 deletions packages/react/src/components/RadioButton/RadioButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,7 @@ class RadioButton extends React.Component {
id={this.uid}
ref={ref}
/>
<label
htmlFor={this.uid}
className={`${prefix}--radio-button__label`}
aria-label={labelText}>
<label htmlFor={this.uid} className={`${prefix}--radio-button__label`}>
<span className={`${prefix}--radio-button__appearance`} />
<span className={innerLabelClasses}>{labelText}</span>
</label>
Expand Down

0 comments on commit 77d8363

Please sign in to comment.