fix(RadioButton): remove unecessary aria-label #4678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 80d8f60 https://deploy-preview-4678--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 80d8f60 |
|
Deploy preview for carbon-components-react ready! Built with commit 80d8f60 https://deploy-preview-4678--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 4a439ac |
|
Deploy preview for carbon-components-react ready! Built with commit 4a439ac https://deploy-preview-4678--carbon-components-react.netlify.com |
|
Deploy preview for the-carbon-components ready! Built with commit 4a439ac https://deploy-preview-4678--the-carbon-components.netlify.com |
emyarod
reviewed
Nov 14, 2019
abbeyhrt
approved these changes
Nov 14, 2019
asudoh
approved these changes
Nov 14, 2019
|
@dakahn Could you update the snapshot? Thanks! |
joshblack
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4491
Really quick one here. Removes an unneeded
aria-labelthat was causing label duplication in Safari and just totally breaking labeling for VoiceOver in Chrome.Testing / Reviewing
In Safari with VO make sure that the label is only read once. In Chrome -- check and make sure the label is read.