fix(OverflowMenu): avoid trapping focus on trigger button (#4688)

carbon-design-system · Nov 19, 2019 · 7cd956b · 7cd956b
1 parent 4fb1856
commit 7cd956b
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/packages/react/src/components/OverflowMenu/OverflowMenu.js b/packages/react/src/components/OverflowMenu/OverflowMenu.js
@@ -326,13 +326,22 @@ class OverflowMenu extends Component {
   };
 
   handleKeyPress = evt => {
-    if (!keyCodeMatches(evt, [keys.Enter, keys.Space])) {
+    if (
+      this.state.open &&
+      keyCodeMatches(evt, [
+        keys.ArrowUp,
+        keys.ArrowRight,
+        keys.ArrowDown,
+        keys.ArrowLeft,
+      ])
+    ) {
       evt.preventDefault();
     }
 
     // only respond to key events when the menu is closed, so that menu items still respond to key events
     if (!this.state.open) {
       if (keyCodeMatches(evt, [keys.Enter, keys.Space])) {
+        evt.preventDefault();
         this.setState({ open: true });
       }
     }